[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Add optional model attribute to the controller element



2010/6/21 Daniel Veillard <veillard redhat com>:
> On Thu, Jun 17, 2010 at 11:15:43PM +0200, Matthias Bolte wrote:
>> This is a step towards controller support for the ESX driver.
>> ---
>>  docs/schemas/domain.rng |    9 +++++++++
>>  src/conf/domain_conf.c  |   34 ++++++++++++++++++++++++++++++++++
>>  src/conf/domain_conf.h  |   11 +++++++++++
>>  src/qemu/qemu_driver.c  |    1 +
>>  4 files changed, 55 insertions(+), 0 deletions(-)
>>

>
>  Looks fine to me but the fack that the attribute is ignored except on
>  ESX driver should probably be documented in some ways

Yes, but we'll need to document the controller element first. For now
I extended the ESX section to cover it.

>
>  ACK,
>
> Daniel
>

Thanks, pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]