[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 3/4] phyp: add storage management driver

On 06/27/2010 09:17 AM, Justin Clift wrote:
> On 06/25/2010 08:32 AM, Eric Blake wrote:
>> From: Eduardo Otubo<otubo linux vnet ibm com>
>> Add the storage management driver to the Power Hypervisor driver.
>> This is a big but simple patch, it's just a new set of functions.
>> This patch includes:
>>   * Storage driver: The set of pool-* and vol-* functions.
>>   * attach-disk function.
>>   * Support for IVM on the new functions.
>> Signed-off-by: Eric Blake<eblake redhat com>
> <snip>
> This commit is causing a segfault here when running "pool-list" in
> unmodified virsh.
> virConnectNumOfStoragePools() calls phypNumOfStoragePools(), which calls
> phypExec(). In this case with session equaling NULL.

virConnectNumOfStoragePools should not call successfully
phypNumOfStoragePools unless the connection URI is for phyp.  Does this
patch clean up the mess?

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]