[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Avoid calling virStorageFileIsSharedFS with NULL



 On 06/28/2010 11:54 PM, Laine Stump wrote:
From: Laine Stump<laine redhat com>

This code was just recently added (by me) and didn't account for the
fact that stdin_path is sometimes NULL. If it's NULL, and
SetSecurityAllLabel fails, a segfault would result.
---
  src/qemu/qemu_driver.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2a277a5..e8c5c35 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3429,7 +3429,7 @@ static int qemudStartVMDaemon(virConnectPtr conn,
      if (driver->securityDriver&&
          driver->securityDriver->domainSetSecurityAllLabel&&
          driver->securityDriver->domainSetSecurityAllLabel(vm, stdin_path)<  0) {
-        if (virStorageFileIsSharedFS(stdin_path) != 1)
+        if (stdin_path&&  virStorageFileIsSharedFS(stdin_path) != 1)
              goto cleanup;
      }


Because this is a trivial and obvious fix, and I didn't want anyone else to hit the segfault, I just pushed it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]