[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Avoid invoking the qemu monitor destroy callback if the constructor fails



On 06/29/2010 05:02 AM, Daniel P. Berrange wrote:
> Some, but not all, codepaths in the qemuMonitorOpen() method
> would trigger the destroy callback. The caller does not expect
> this to be invoked if construction fails, only during normal
> release of the monitor. This resulted in a possible double-unref
> of the virDomainObjPtr, because the caller explicitly unrefs
> the virDomainObjPtr  if qemuMonitorOpen() fails
> 
> * src/qemu/qemu_monitor.c: Don't invoke destroy callback from
>   qemuMonitorOpen() failure paths

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]