[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Update on PHP libvirt



Sorry.  Here's the diff -urp output.

The compiler output is:
/root/php-libvirt/libvirt.c:19: error: duplicate ‘static’


David King
Goshen College ITS
davidwk goshen edu
574-535-7726


On 06/29/2010 11:38 AM, Eric Blake wrote:
> On 06/29/2010 09:27 AM, David W King wrote:
>> I'm running Ubuntu 10.04 with php 5.3.2.  In order to get the extension
>> to compile I had to apply the attached patch.
> 
> Could you please resend that patch as a context diff?  ed script diffs
> are practically impossible to apply correctly if anything else has
> touched the file.
> 
> Our hacking instructions give more hints on how to generate a worthwhile
> patch:
> http://libvirt.org/git/?p=libvirt.git;a=blob;f=HACKING
> 
> Also, it would help to paste the actual compiler error that you are
> trying to address with your patch.
> 
--- php-libvirt/libvirt.c	2010-06-29 11:10:41.398420032 -0400
+++ php-libvirt-0.3-alpha/libvirt.c	2010-03-11 10:27:42.000000000 -0500
@@ -15,7 +15,7 @@ int le_libvirt_domain; 
 
 ZEND_DECLARE_MODULE_GLOBALS(libvirt)
 
-//static
+static
 ZEND_BEGIN_ARG_INFO_EX(arginfo_libvirt_connect, 0, 0, 0)
 	ZEND_ARG_INFO(0, url)
         ZEND_ARG_INFO(0, readonly)

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]