[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] vbox: Let configure detect/set the XPCOMC directory



On 06/29/2010 03:29 PM, Matthias Bolte wrote:
> This allows the user to give an explicit path to configure
> 
>   ./configure --with-vbox=/path/to/virtualbox
> 
> instead of having the VirtualBox driver probe a set of possible
> paths at runtime. If no explicit path is specified then configure
> probes the set of "known" paths.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=609185
> ---
> 
> v2:
>  - address Eric's comments
>    - wrap AC_HELP_STRING at 80 columns
>    - replace the if/else with a for loop, much nicer, indeed :)
>    - use AC_DEFINE_UNQUOTED instead of AC_SUBST to define VBOX_XPCOMC_DIR

Nicer indeed!

It ends up doing
 #define VBOX_CXPCOMC_DIR ""
if you don't have virtualbox installed, but this should be harmless.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]