[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] Refactor XML parsing code



On Thu, Feb 25, 2010 at 01:12:47PM +0100, Daniel Veillard wrote:
> On Wed, Feb 24, 2010 at 11:07:31PM +0100, Jiri Denemark wrote:
> > Almost identical XML parsing code for either strings or files was copied
> > 15 times. Since it was needed on two other places for parsing CPU XML
> > strings with correct error reporting, I decided to factor the parsing code
> > out to xml.c and used this one implementation in all other places.
> 
>  looking very quickly, this looks sensible, but I can't fully review
>  this right now, ACK on principle though, maybe this can wait for 0.7.8.

  Okay, reread them, looks just fine by me, ACK, let's push them
once 0.7.7 is out :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]