[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/6] Add new clock mode allowing variable adjustments



On Mon, Mar 01, 2010 at 08:12:23PM +0100, Jim Meyering wrote:
> Daniel P. Berrange wrote:
> ...
> >> > diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
> >> > index 1ff0944..d295bfe 100644
> >> > --- a/docs/schemas/domain.rng
> >> > +++ b/docs/schemas/domain.rng
> >> > @@ -297,12 +297,24 @@
> >> >    <define name="clock">
> >> >      <optional>
> >> >        <element name="clock">
> >> > -        <attribute name="offset">
> >> > -          <choice>
> >> > +	<choice>
> >> > +          <attribute name="offset">
> >>
> >>   hum isn't that inserting tabs in the XML that we remove from time to
> >>   time :-) ?
> >
> > Hmm, our syntax-check only seems to validate no-TABS for source
> > code files, not schemas/docs
> 
> Here's the change to the syntax-check rule,
> followed by the change to the code to make those files comply.
> If everyone agrees, I'll reverse the order before pushing,
> so that make syntax-check passes after each commit.

ACK, this makes sense - since we clearly keep re-introducing tabs
in these files.

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]