[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH option 1] Use fallocate directly if possible



According to Eric Blake on 3/2/2010 8:50 AM:
>> +AC_CHECK_FUNCS([cfmakeraw regexec uname sched_getaffinity getuid getgid posix_fallocate mmap fallocate])
> 
> This is already a long line, and you made it longer.  Autoconf will let
> you line-wrap the list to AC_CHECK_FUNCS; it splits on whitespace,
> including newlines.  And maybe it makes more sense to use
> AC_CHECK_FUNCS_ONCE instead of AC_CHECK_FUNCS (oh right, 2.59 didn't have
> the former).

Then again, we use gnulib, and gnulib guarantees AC_CHECK_FUNCS_ONCE even
for autoconf 2.59.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]