[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH option 1] Use fallocate directly if possible



On Tue, Mar 02, 2010 at 08:50:23AM -0700, Eric Blake wrote:
> According to Jiri Denemark on 3/2/2010 8:26 AM:
> > If fallocate() is present, use it directly instead of posix_allocate().
> > If it is not support by the kernel or filesystem, emulate it using
> > mmap() or write().
> > 
> > This change is to work around slow fallocate emulation done by glibc's
> > posix_allocate() when used on files opened with O_DSYNC.
[..]
> >  
> > -#ifdef HAVE_POSIX_FALLOCATE
> > +#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE)
> 
> Redundant parenthesis.  I know upstream gnulib's maint.mk warns about
> them; did we turn them off in libvirt's 'make syntax-check'?

  Hum,  what's redundant here ?

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]