[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: silence compiler warning



On Tue, Mar 02, 2010 at 05:19:01PM -0700, Eric Blake wrote:
> gcc warns:
> virsh.c:1879: warning: '0' flag ignored with '-' flag in gnu_printf format
> 
> * tools/virsh.c (cmdDomjobinfo): Delete useless flag.
> ---
>  tools/virsh.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/virsh.c b/tools/virsh.c
> index a6a637d..65487ed 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -1876,27 +1876,27 @@ cmdDomjobinfo(vshControl *ctl, const vshCmd *cmd)
>              vshPrint(ctl, "%-17s %-12llu ms\n", _("Time remaining:"), info.timeRemaining);
>          if (info.dataTotal || info.dataRemaining || info.dataProcessed) {
>              val = prettyCapacity(info.dataProcessed, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("Data processed:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("Data processed:"), val, unit);
>              val = prettyCapacity(info.dataRemaining, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("Data remaining:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("Data remaining:"), val, unit);
>              val = prettyCapacity(info.dataTotal, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("Data total:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("Data total:"), val, unit);
>          }
>          if (info.memTotal || info.memRemaining || info.memProcessed) {
>              val = prettyCapacity(info.memProcessed, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("Memory processed:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("Memory processed:"), val, unit);
>              val = prettyCapacity(info.memRemaining, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("Memory remaining:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("Memory remaining:"), val, unit);
>              val = prettyCapacity(info.memTotal, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("Memory total:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("Memory total:"), val, unit);
>          }
>          if (info.fileTotal || info.fileRemaining || info.fileProcessed) {
>              val = prettyCapacity(info.fileProcessed, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("File processed:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("File processed:"), val, unit);
>              val = prettyCapacity(info.fileRemaining, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("File remaining:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("File remaining:"), val, unit);
>              val = prettyCapacity(info.fileTotal, &unit);
> -            vshPrint(ctl, "%-17s %-0.3lf %s\n", _("File total:"), val, unit);
> +            vshPrint(ctl, "%-17s %-.3lf %s\n", _("File total:"), val, unit);
>          }
>      } else {
>          ret = FALSE;

  On one hand it's a cleanup, so supposed to wait, on the other hand it
looks fairly safe and touch only virsh not the library itself, so I'm
fine pushing it now, ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]