[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: silence compiler warning



According to Jim Meyering on 3/3/2010 2:03 AM:
> Eric Blake wrote:
>> gcc warns:
>> virsh.c:1879: warning: '0' flag ignored with '-' flag in gnu_printf format
> 
> Odd...  I don't get that warning on F12 or rawhide.
> Which version of gcc are you using?
> Any added options, beyond those provided by this:
> ./autogen.sh --enable-compile-warnings=maximum

Huh - I had to go back and see what breadcrumbs show for how I had
configured.  I'm using F12, gcc 4.4.3, and ./config.status --version reports:

configured by ./configure, generated by GNU Autoconf 2.63,
  with options "'CFLAGS=-Wall' '-C'"

Apparently, in this build tree, I _didn't_ use --enable-compile-warnings,
but had manually set CFLAGS myself to a subset of warnings (note to self -
next time I bootstrap, I should use the configure option rather than
trying to do it by hand).  So is there something in plain -Wall that
accidently gets turned back off by --enable-compile-warnings=maximum?

Meanwhile, it would be nice to add -fdiagnostics-show-option to the set of
warning flags attempted by --enable-compile-warnings.  That would have
told us which particular reason I got the warning.  Or perhaps even use
the gnulib module manywarnings, rather than hand-rolling
LIBVIRT_COMPILE_WARNINGS, so that we pick up benefits from gnulib folks
whenever better approaches for enabling warnings are implemented.  I'll
start a patch series along those lines (post 0.7.7).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]