[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Get thread and socket information in virsh nodeinfo.



On 03/08/2010 09:22 AM, Daniel Veillard wrote:
> On Fri, Mar 05, 2010 at 02:06:34PM -0500, Chris Lalancette wrote:
>> The current code for "nodeinfo" is pretty naive
>> about socket and thread information.  To determine the
>> sockets, it just takes the number of cpus and divides
>> by the number of cores.  For the thread count, it always
>> sets it to 1.  With more recent Intel machines, however,
>> hyperthreading is again an option, meaning that these
>> heuristics no longer work and give bogus numbers.  This
>> patch goes through /sys to get the additional
>> information so we properly report it.
>>
>> Note that I had to edit the tests not to report on
>> socket and thread counts, since these are determined
>> dynamically now.
>>
>> v2: As pointed out by Eric Blake, gnulib provides
>>     count-one-bits (which is LGPLv2+).  Use it instead
>>     of a hand-coded popcnt.
>>
>> Signed-off-by: Chris Lalancette <clalance redhat com>
> 
>   ACK to this version too, better actually !
> 
> Daniel
> 

Great, thanks.  I've pushed this now.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]