[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Make virDomainGetXMLDesc output cache settings even if no special driverName is set



On 03/08/2010 01:46 PM, Soren Hansen wrote:
> If a special cache strategy for a disk has been specified in a domain
> definition, but no driverName has been set, virDomainGetXMLDesc will not
> include the <driver> tag at all.
...
> 
> -    if (def->driverName) {
> -        virBufferVSprintf(buf, "      <driver name='%s'", def->driverName);
> +    if (def->driverName || def->driverType || def->cachemode) {
> +        virBufferVSprintf(buf, "      <driver");
> +        if (def->driverName)
> +            virBufferVSprintf(buf, " name='%s'", def->driverName);
>          if (def->driverType)

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]