[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix copy&paste typos in virProcessInfoGetAffinity



On 03/09/2010 06:59 AM, Jiri Denemark wrote:
> +++ b/src/util/processinfo.c
> @@ -130,31 +130,31 @@ realloc:
                        ^^^^^^^^

Is there a policy on indentation of labels?  By default, emacs starts
labels in column 2, so that utilities that expect only function names to
appear in column 1 behave in a more predictable manner.  I'm not sure
what indent(1) does in this case.  At any rate, the git hunk header
detection regexp is an example of an external tool that expects to find
only function names on column 1, and which is being thrown off by the
presence of an intermediate label also in that column.


>          virReportSystemError(errno,
> -                             _("cannot set CPU affinity on process %d"), pid);
> +                             _("cannot get CPU affinity of process %d"), pid);

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]