[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [libvirt] [PATCH 1/2] hacking: fix typos
- From: Jim Meyering <jim meyering net>
- To: Eric Blake <eblake redhat com>
- Cc: libvir-list redhat com
- Subject: Re: [libvirt] [PATCH 1/2] hacking: fix typos
- Date: Tue, 09 Mar 2010 17:03:10 +0100
Eric Blake wrote:
> * docs/hacking.html.in (committers): Fix spelling and grammar.
> ---
>
> Per the very text I'm editing, this counts as trivial :)
>
> docs/hacking.html.in | 26 +++++++++++++++-----------
> 1 files changed, 15 insertions(+), 11 deletions(-)
...
Applied, with these additional changes:
diff --git a/HACKING b/HACKING
index be8725d..b6f63dd 100644
--- a/HACKING
+++ b/HACKING
@@ -369,8 +369,8 @@ of arguments.
The AUTHORS files indicates the list of people with commit acces right
who can actually merge the patches.
-The general rule for commiting patches is to make sure it has been reviewed
-properly in the mailing-list first, usually if a couple of persons gave an
+The general rule for commiting a patch is to make sure it has been reviewed
+properly in the mailing-list first, usually if a couple of people gave an
ACK or +1 to a patch and nobody raised an objection on the list it should
be good to go. If the patch touches a part of the code where you're not the
main maintainer or not have a very clear idea of how things work, it's better
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]