[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] hacking: fix typos



On 03/09/2010 09:22 AM, Jim Meyering wrote:
> Eric Blake wrote:
>> On 03/09/2010 09:03 AM, Jim Meyering wrote:
>>>  The AUTHORS files indicates the list of people with commit acces right
>>>  who can actually merge the patches.
>>>
>>> -The general rule for commiting patches is to make sure it has been reviewed
>>> -properly in the mailing-list first, usually if a couple of persons gave an
>>> +The general rule for commiting a patch is to make sure it has been reviewed
>>> +properly in the mailing-list first, usually if a couple of people gave an
>>
>> Sorry for not spotting it sooner, but s/commiting/committing/ (2 t's)
> 
> No problem.
> I made a quick pass through it and fixed a bunch more:

Actually, the whole point is that HACKING and docs/hacking.html.in are
more or less duplicates of one another, and someone volunteered to make
HACKING be autogenerated from the html version.  Therefore, patching
HACKING is not worth much (otherwise I would have patched both files in
the first place); but your grammar change to go from 'committing
patches' to 'committing a patch' should be flowed back to the html version.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]