[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] build: enforce preprocessor indentation



On 03/09/2010 01:48 PM, Jim Meyering wrote:
> Eric Blake wrote:
>> On 03/09/2010 10:02 AM, Eric Blake wrote:
>>> * cfg.mk (sc_preprocessor_indentation): New syntax-check rule.
>>
>> I don't see 1/2 in the archives yet; perhaps it was held up by
>> moderation, because it is big?  (400k)
>>
>> At any rate, I've pushed it to my cloned repo, if that makes life any
>> easier:
>> http://repo.or.cz/w/libvirt/ericb.git/commitdiff/4d3b7e06bc8e
>>
>> Patch 1/2 is entirely mechanical; the most helpful review would be on
>> whether any of the affected files are normally generated, where either
>> we add exceptions, or fix the generator, so as to avoid regressions when
>> those files are regenerated.
>>
>> commit 4d3b7e06bc8e2e76584da369406df0909c63f2d4
>> Author: Eric Blake <eblake redhat com>
>> Date:   Tue Mar 9 09:33:48 2010 -0700
>>
>>     build: consistently indent preprocessor directives
>>
>>     * global: patch created by running:
>>     for f in $(git ls-files '*.[ch]') ; do
>>        cppi $f > $f.t && mv $f.t $f
>>     done
> 
> I'll go ahead and push this if no one speaks up soon.
> Rather than downloading and applying the patch, I ran the command
> and committed as you.

By "this", you mean patch 1/2, correct?  I just want to make sure
we don't make syntax-check dependent on a non-existent
cppi package until we have a fallback plan.  (My automated build
testing does "make syntax-check", and I don't want it to fail
every night now because cppi is not packaged)

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]