[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] build: enforce preprocessor indentation



Chris Lalancette wrote:
...
>>> commit 4d3b7e06bc8e2e76584da369406df0909c63f2d4
>>> Author: Eric Blake <eblake redhat com>
>>> Date:   Tue Mar 9 09:33:48 2010 -0700
>>>
>>>     build: consistently indent preprocessor directives
>>>
>>>     * global: patch created by running:
>>>     for f in $(git ls-files '*.[ch]') ; do
>>>        cppi $f > $f.t && mv $f.t $f
>>>     done
>>
>> I'll go ahead and push this if no one speaks up soon.
>> Rather than downloading and applying the patch, I ran the command
>> and committed as you.
>
> By "this", you mean patch 1/2, correct?  I just want to make sure

Yes.  The one induced by the for loop command,
and whose header I quoted.

> we don't make syntax-check dependent on a non-existent
> cppi package until we have a fallback plan.  (My automated build
> testing does "make syntax-check", and I don't want it to fail
> every night now because cppi is not packaged)

I wouldn't push the enforcement patch until I'm sure
it will pass (or skip) for everyone.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]