[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Silence compiler complaints about non-literal format strings



On 03/11/2010 04:12 PM, Laine Stump wrote:
> * src/util/macvtap.c: replace _("....") with "%s", _("...") in two places
> ---
>  src/util/macvtap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/util/macvtap.c b/src/util/macvtap.c
> index 736cbaf..999e670 100644
> --- a/src/util/macvtap.c
> +++ b/src/util/macvtap.c
> @@ -435,13 +435,13 @@ link_add(virConnectPtr conn,
>  
>  malformed_resp:
>      ReportError(conn, VIR_ERR_INTERNAL_ERROR,
> -                _("malformed netlink response message"));
> +                "%s", _("malformed netlink response message"));
>      VIR_FREE(recvbuf);
>      return -1;
>  
>  buffer_too_small:
>      ReportError(conn, VIR_ERR_INTERNAL_ERROR,
> -                _("internal buffer is too small"));
> +                "%s", _("internal buffer is too small"));
>      return -1;
>  }
>  

ACK

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]