[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Move username and password helper functions to util.c



2010/3/15 Daniel P. Berrange <berrange redhat com>:
> On Sun, Mar 14, 2010 at 10:07:24PM +0100, Matthias Bolte wrote:
>> ---
>>  src/esx/esx_driver.c |    8 ++--
>>  src/esx/esx_util.c   |   83 ----------------------------------------------
>>  src/esx/esx_util.h   |    7 ----
>>  src/util/util.c      |   89 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  src/util/util.h      |    5 +++
>>  5 files changed, 98 insertions(+), 94 deletions(-)
>
> ACK in principle, but I think we should start a new file for these helpers,
> rather than continue to add more to 'util.c' since it is getting rather large.
> Lets keep util.c/h for POFIX file/path/process related wrappers.
>
>
> Daniel
>

Okay, any suggestion for a filename?

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]