[libvirt] [PATCH] xenapi: Don't leak url and caps in case of error
Daniel P. Berrange
berrange at redhat.com
Mon Mar 15 15:28:49 UTC 2010
On Sun, Mar 14, 2010 at 10:09:45PM +0100, Matthias Bolte wrote:
> ---
> src/xenapi/xenapi_driver.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c
> index 9a38e3f..7d0b748 100644
> --- a/src/xenapi/xenapi_driver.c
> +++ b/src/xenapi/xenapi_driver.c
> @@ -172,9 +172,12 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUS
> VIR_FREE(password);
>
> if (privP != NULL) {
> + virCapabilitiesFree(privP->caps);
> +
> if (privP->session != NULL)
> xenSessionFree(privP->session);
>
> + VIR_FREE(privP->url);
> VIR_FREE(privP);
> }
>
ACK
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list