[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/9] Implement RPC client for vol wiping



On Mon, Mar 15, 2010 at 10:13:28PM -0400, David Allan wrote:
> ---
>  src/remote/remote_driver.c |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)
> 
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 11513bd..0ee038e 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -5538,6 +5538,32 @@ done:
>  }
> 
>  static int
> +remoteStorageVolWipe(virStorageVolPtr vol,
> +                     unsigned int flags)
> +{
> +    int rv = -1;
> +    remote_storage_vol_wipe_args args;
> +    struct private_data *priv = vol->conn->storagePrivateData;
> +
> +    remoteDriverLock(priv);
> +
> +    make_nonnull_storage_vol(&args.vol, vol);
> +    args.flags = flags;
> +
> +    if (call(vol->conn, priv, 0, REMOTE_PROC_STORAGE_VOL_WIPE,
> +             (xdrproc_t) xdr_remote_storage_vol_wipe_args, (char *) &args,
> +             (xdrproc_t) xdr_void, (char *) NULL) == -1)
> +        goto done;
> +
> +    rv = 0;
> +
> +done:
> +    remoteDriverUnlock(priv);
> +    return rv;
> +}
> +
> +
> +static int
>  remoteStorageVolGetInfo (virStorageVolPtr vol, virStorageVolInfoPtr info)
>  {
>      int rv = -1;
> @@ -9202,6 +9228,7 @@ static virStorageDriver storage_driver = {
>      .volCreateXML = remoteStorageVolCreateXML,
>      .volCreateXMLFrom = remoteStorageVolCreateXMLFrom,
>      .volDelete = remoteStorageVolDelete,
> +    .volWipe = remoteStorageVolWipe,
>      .volGetInfo = remoteStorageVolGetInfo,
>      .volGetXMLDesc = remoteStorageVolDumpXML,
>      .volGetPath = remoteStorageVolGetPath,

  ACK,

At some point I would like to convert the storage_driver definition to
use the old format, which allow to easilly see what are the missing
entry points, like we do for domains, but not urgent :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]