[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command



On 03/18/2010 05:17 AM, Jiri Denemark wrote:
>>> +        res = strtod(arg->data, &end_p);
>>
>> Should we be using the gnulib strtod module here?
> 
> Why? It doesn't seem to be any better than C89 strtod. Or did I miss anything?

strtod is broken on a number of platforms in various ways; most of them
related to parsing the new formats required by C99, but there are some
other bugs even with C89 parsing as well:

http://git.sv.gnu.org/cgit/gnulib.git/tree/doc/posix-functions/strtod.texi

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]