[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCHv2] maint: enforce recent copyright style



* cfg.mk (sc_copyright_format): New rule.
---

Jim wrote:
> In each diagnostic, it'd be nice to say what's missing.
> "Inc." in the first, "(C)" in the second.
> 
> In the second, isn't s/correct/consistent/ more appropriate?
> Or is there some legal guidance saying that the (C) is required?
> I seem to recall reading that at least with FSF copyrights,
> the "(C)" is optional, and without legal value.

Yes, the FSF ruling was that (C) is optional, at least for
FSF-copyrighted files.  I don't know if Red Hat has another
policy; but hopefully the wording below works better.


 cfg.mk |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 9fc2d66..2d0d278 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -269,6 +269,15 @@ sc_preprocessor_indentation:
 	  echo '$(ME): skipping test $@: cppi not installed' 1>&2;	\
 	fi

+sc_copyright_format:
+	@$(VC_LIST_EXCEPT) | xargs grep -ni 'copyright .*Red 'Hat	\
+	  | grep -v Inc							\
+	  && { echo '$(ME): Red Hat copyright is missing Inc' 1>&2;	\
+	       exit 1; } || :
+	@$(VC_LIST_EXCEPT) | xargs grep -ni 'copyright [^(].*Red 'Hat	\
+	  && { echo '$(ME): consistently use (C) in Red Hat copyright' 1>&2; \
+	       exit 1; } || :
+
 # We don't use this feature of maint.mk.
 prev_version_file = /dev/null

-- 
1.6.6.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]