[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/14] Add build support



On 03/18/2010 09:16 AM, Stefan Berger wrote:
> This patch adds build support for the network filtering framework.
> 
> Signed-off-by: Stefan Berger <stefanb us ibm com>
> 

Some nits, but I'll let others more familiar with the process of API
expansion give an actual ack/nak review.

> +NWFILTER_CONF_SOURCES =                                         \
> +		$(NWFILTER_PARAM_CONF_SOURCES)			\
> +		conf/nwfilter_conf.c conf/nwfilter_conf.h

What's with the mix between tabs and spaces before the \?

Moreover, it seems a bit odd to hook up the Makefile support in 2/14
when the new files don't exist until 12/14.  But I guess that's okay as
long as the automake conditional that enables this block of code doesn't
trigger until the files exist.

> fi
> +if test "$with_nwfilter" = "yes" ; then
> +  AC_DEFINE_UNQUOTED([WITH_NWFILTER], 1, [whether local network filter management driver is available])
> +fi

You can use AC_DEFINE instead of AC_DEFINE_UNQUOTED here, since you
aren't doing any shell expansion on either WITH_NWFILTER or 1.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]