[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: ensure virMutexInit is not recursive



Daniel P. Berrange wrote:
> On Thu, Mar 18, 2010 at 11:32:16AM -0600, Eric Blake wrote:
>> POSIX states that creation of a mutex with default attributes
>> is unspecified whether the mutex is recursive or non-recursive.
>> We specifically want non-recursive (deadlock is desirable in
>> flushing out coding bugs that used our mutex incorrectly).
>>
>> * src/util/threads-pthread.c (virMutexInit): Specifically request
>> non-recursive mutex, rather than relying on unspecified default.
...
> ACK, this is good.

Pushed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]