[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/5] Wire protocol and dispatcher for virDomainMigrateSetMaxDowntime



On Thu, Mar 18, 2010 at 08:12:45PM +0100, Jiri Denemark wrote:
[...]
> diff --git a/src/remote/remote_protocol.h b/src/remote/remote_protocol.h
> index f76e6e5..34d49fa 100644
> --- a/src/remote/remote_protocol.h
> +++ b/src/remote/remote_protocol.h
> @@ -4,51 +4,51 @@
>   */
>  
>  #ifndef _RP_H_RPCGEN
> -# define _RP_H_RPCGEN
> +#define _RP_H_RPCGEN
>  
> -# include <rpc/rpc.h>
> +#include <rpc/rpc.h>
>  
>  
> -# ifdef __cplusplus
> +#ifdef __cplusplus
>  extern "C" {
> -# endif
> +#endif
>  
> -# include "internal.h"
> -# include <arpa/inet.h>
> -# define REMOTE_MESSAGE_MAX 262144
> -# define REMOTE_MESSAGE_HEADER_MAX 24
> -# define REMOTE_MESSAGE_PAYLOAD_MAX 262120
> -# define REMOTE_STRING_MAX 65536
> +#include "internal.h"
> +#include <arpa/inet.h>
> +#define REMOTE_MESSAGE_MAX 262144
> +#define REMOTE_MESSAGE_HEADER_MAX 24
> +#define REMOTE_MESSAGE_PAYLOAD_MAX 262120
> +#define REMOTE_STRING_MAX 65536

 painful because it's generated, if you don't have cppi installed
make "syntax-check" won't complain, but I'm afraid it will for those
where this is present. I think the patch is fine, we just need to make
sure that generated file is not checked for the cppi test,

[...]
> @@ -1703,7 +1710,8 @@ enum remote_procedure {
>      REMOTE_PROC_DOMAIN_DETACH_DEVICE_FLAGS = 161,
>      REMOTE_PROC_CPU_BASELINE = 162,
>      REMOTE_PROC_DOMAIN_GET_JOB_INFO = 163,
> -    REMOTE_PROC_DOMAIN_ABORT_JOB = 164
> +    REMOTE_PROC_DOMAIN_ABORT_JOB = 164,
> +    REMOTE_PROC_DOMAIN_MIGRATE_SET_MAX_DOWNTIME = 165
>  
>      /*
>       * Notice how the entries are grouped in sets of 10 ?

  note that the patch will probably have to be regenerated once Dave
Allan new interface is pushed too, as both patches use 165

  ACK, but may have to be regenerated

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]