[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/5] Add migrate-setmaxdowntime command to virsh



> > +static const vshCmdOptDef opts_migrate_setmaxdowntime[] = {
> > +    {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")},
> > +    {"downtime", VSH_OT_DATA, VSH_OFLAG_REQ, N_("maximum tolerable downtime (in nanoseconds) for migration")},
> > +    {NULL, 0, 0, NULL}
> > +};
> 
>   Maybe for virsh command line we could use milliseconds, so that
> a "setmaxdowntime foo 1" can still have a chance to actually work,
> instead of blocking forever.
...
> On one hand from an usability POV it looks more reasonnable to use
> millisecs here, on the other hand each time we make virsh CLI and
> libvirt API diverge in some way this leads to confusion.
> 
>   So I'm still undecided :-)

Or we can do what Daniel suggested and use milliseconds in the API as well.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]