[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/5] Introduce virDomainMigrateSetMaxDowntime API



> > > This API call sets maximum tolerable time for which the domain is allowed to be
> > > paused at the end of live migration. It's supposed to be called while the
> > > domain is being live-migrated as a reaction to migration progress.
> > 
> > Changes in version 3:
> > - use milliseconds instead of nanoseconds both internally and in API
> > - correct suffix for qemu monitor commands
> > 
> > > Changes in version 2:
> > > - API renamed to reflect it's maximum downtime
> > > - new flags parameter for the future
> > > - qemu implementation was fixed so that the call is allowed iff the domain is
> > >   being migrated
> > > - --downtime parameter of virsh migrate command was removed in favor of new
> > >   virsh migrate-setmaxdowntime which can be run independently
> > > - virsh accepts downtime as nanoseconds instead of floating-point seconds
> > >   (shells don't deal with floating-point numbers well)
> 
>   ACK,
> 
> looks fine to me now !

Ah, I forgot to send a note here... I fixed virDomainMigrateSetMaxDowntime
implementation in qemu driver to complain in case flags != 0 and pushed the
patchset on Friday.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]