[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Generate method mappings via macros



On Mon, Mar 22, 2010 at 01:53:50AM +0100, Matthias Bolte wrote:
> This is actually a consequence of the reworked required parameter
> checking: Unify the required parameter check into a Validate function
> instead of doing it separately im the (de)serialization part.
> 
> The required parameter checking for the mapped methods parameter was
> done in the (de)serialize functions before. Now it's explicitly done
> in the mapped method itself.
> ---
> 
> git produces a somwhat confusing diff for esx_vi_methods.c, basically
> the whole file is rewritten.

Indeed !  The new code has alot less manual duplication of XML generation,
so ACK

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]