[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/15] Generate libvirt.def from libvirt.syms



On Mon, Mar 22, 2010 at 02:25:36AM +0100, Matthias Bolte wrote:
> The MinGW linker needs the libvirt.def file.
> ---
>  configure.ac    |    5 +++++
>  src/.gitignore  |    1 +
>  src/Makefile.am |   15 +++++++++++----
>  3 files changed, 17 insertions(+), 4 deletions(-)

> diff --git a/src/Makefile.am b/src/Makefile.am
> index 0aa3443..fea1bd3 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -828,7 +828,7 @@ EXTRA_DIST += \
>    libvirt_macvtap.syms		\
>    libvirt_daemon.syms
>  
> -BUILT_SOURCES = libvirt.syms
> +BUILT_SOURCES = libvirt.syms libvirt.def
>  
>  libvirt.syms: libvirt_public.syms $(USED_SYM_FILES)
>  	rm -f $ -tmp $@
> @@ -844,18 +844,25 @@ libvirt.syms: libvirt_public.syms $(USED_SYM_FILES)
>  	chmod a-w $ -tmp
>  	mv $ -tmp libvirt.syms
>  
> +libvirt.def: libvirt.syms
> +	rm -f -- $ -tmp $@
> +	printf 'EXPORTS\n' > $ -tmp
> +	sed -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/\(.*\)\;/\1/g' $^ >> $ -tmp
> +	chmod a-w $ -tmp
> +	mv $ -tmp libvirt.def

Hmm, this is effectively exporting all our private symbols on Win32 too :-(

I thought the GCC/LD toolchain on Mingw already knew about the current
libvirt.syms file format ?

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]