[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/15] gnulib: Add usleep for MinGW builds



On Mon, Mar 22, 2010 at 10:15:35AM -0600, Eric Blake wrote:
> On 03/22/2010 08:54 AM, Daniel P. Berrange wrote:
> > On Mon, Mar 22, 2010 at 02:25:31AM +0100, Matthias Bolte wrote:
> >> ---
> >>  bootstrap.conf |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/bootstrap.conf b/bootstrap.conf
> >> index 157092f..fb862ad 100644
> >> --- a/bootstrap.conf
> >> +++ b/bootstrap.conf
> >> @@ -56,6 +56,7 @@ strsep
> >>  sys_stat
> >>  time_r
> >>  useless-if-before-free
> >> +usleep
> >>  vasprintf
> >>  verify
> >>  vc-list-files
> >> -- 
> > 
> > ACK
> 
> POSIX 2008 delisted usleep as an obsolete interface; it has some
> usability issues when compared to nanosleep.  While gnulib at least
> fixes the worst of the portability problems (namely, the fact that
> usleep is not required to sleep longer than 1 second, even though it can
> sleep over 4000 seconds on glibc), I'm wondering if we should instead be
> converting all existing uses of usleep to a more modern interface.

Sure, we use nansleep in the QEMU driver already too


Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]