[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Make the conf parser compare names case insensitive in VMX mode



On Wed, Mar 24, 2010 at 02:12:14AM +0100, Matthias Bolte wrote:
> The keys of entries in a VMX file are case insensitive. Both scsi0:1.fileName
> and scsi0:1.filename are valid. Therefore, make the conf parser compare names
> case insensitive in VMX mode to accept every capitalization variation.
> 
> Also add test cases for this.
> ---
>  src/util/conf.c                                  |    5 ++-
>  tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx |   51 ++++++++++++++++++++++
>  tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml |   25 +++++++++++
>  tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx |   51 ++++++++++++++++++++++
>  tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml |   25 +++++++++++
>  tests/vmx2xmltest.c                              |    9 ++++
>  6 files changed, 165 insertions(+), 1 deletions(-)
>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx
>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml
>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx
>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml

  Patch for issue raised privately by Paul Dorman, looks fine to me,
  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]