[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 2/2] maint: update syntax-check rule to also catch test's -o operator



* cfg.mk (sc_prohibit_test_minus_a): Rename...
(sc_prohibit_test_minus_ao): ...and flag '-o', too.
---
 cfg.mk |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 4302338..27cfca4 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -269,11 +269,14 @@ sc_preprocessor_indentation:
 	  echo '$(ME): skipping test $@: cppi not installed' 1>&2;	\
 	fi

-# Using test's -a operator is not portable.
-sc_prohibit_test_minus_a:
+# Using test's -a and -o operators is not portable.
+sc_prohibit_test_minus_ao:
 	@re='\<test .+ -[a] '						\
 	msg='use "test C1 && test C2, not "test C1 -''a C2"'		\
 	  $(_prohibit_regexp)
+	@re='\<test .+ -[o] '						\
+	msg='use "test C1 || test C2, not "test C1 -''o C2"'		\
+	  $(_prohibit_regexp)

 sc_copyright_format:
 	@$(VC_LIST_EXCEPT) | xargs grep -ni 'copyright .*Red 'Hat	\
-- 
1.6.6.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]