[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: teach syntax-check that virDomainDefFree has free-like semantics



On 03/25/2010 02:56 PM, Jim Meyering wrote:
> Thanks for highlighting that.
> Our syntax-check rule should have caught it.
> With the following change, it does, along with one other:
> 
>     src/conf/domain_conf.c: if (domain->newDef)
>                     virDomainDefFree(domain->newDef)
>     src/test/test_driver.c: if (def)
>             virDomainDefFree(def)
>     maint.mk: found useless "if" before "free" above
>     make: *** [sc_avoid_if_before_free] Error 1
> 
> This also fixes the one not fixed by Jiri's change.

ACK

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]