[libvirt] [PATCH] esx: Make the conf parser compare names case insensitive in VMX mode

Paul Dorman paul.dorman at gmail.com
Fri Mar 26 01:00:40 UTC 2010


Patch successfully resolves this issue. Tested with previously failing
domains.

Thanks,
Paul

On Thu, Mar 25, 2010 at 9:05 AM, Matthias Bolte <
matthias.bolte at googlemail.com> wrote:

> 2010/3/24 Daniel Veillard <veillard at redhat.com>:
> > On Wed, Mar 24, 2010 at 02:12:14AM +0100, Matthias Bolte wrote:
> >> The keys of entries in a VMX file are case insensitive. Both
> scsi0:1.fileName
> >> and scsi0:1.filename are valid. Therefore, make the conf parser compare
> names
> >> case insensitive in VMX mode to accept every capitalization variation.
> >>
> >> Also add test cases for this.
> >> ---
> >>  src/util/conf.c                                  |    5 ++-
> >>  tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx |   51
> ++++++++++++++++++++++
> >>  tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml |   25 +++++++++++
> >>  tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx |   51
> ++++++++++++++++++++++
> >>  tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml |   25 +++++++++++
> >>  tests/vmx2xmltest.c                              |    9 ++++
> >>  6 files changed, 165 insertions(+), 1 deletions(-)
> >>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx
> >>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml
> >>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx
> >>  create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml
> >
> >  Patch for issue raised privately by Paul Dorman, looks fine to me,
> >  ACK,
> >
> > Daniel
> >
>
> Thanks, pushed.
>
> Matthias
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100326/8de7a7b5/attachment-0001.htm>


More information about the libvir-list mailing list