[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [RFC] Use enum of virDomainNetType



On Thu, Mar 25, 2010 at 02:50:50PM -0400, Stefan Berger wrote:
> To find out where the net type 'direct' needs to be handled I introduced
> the 'enum virDomainNetType' in the virDomainNetDef structure and let the
> compiler tell me where the case statement is missing. Then I added the
> unhandled device statement to the UML driver.
> 
> Signed-off-by; Stefan Berger <stefanb us ibm com>

  yeah, it's a generally useful technique, fine as long as the enum
doesn't end up in public structure where we need to preserve ABI it's
fine,

  pushed, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]