[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Introduce UPDATE_CPU flag for virDomainGetXMLDesc



On Fri, Mar 26, 2010 at 02:11:36PM +0100, Jiri Denemark wrote:
> This flag is used in migration prepare step to send updated XML
> definition of a guest.
> 
> Also ``virsh dumpxml --update-cpu [--inactive] guest'' command can be
> used to see the updated CPU requirements.
> ---
>  include/libvirt/libvirt.h.in |    5 ++-
>  src/libvirt.c                |    3 +-
>  src/qemu/qemu_driver.c       |   54 +++++++++++++++++++++++++++++++++++------
>  tools/virsh.c                |    4 +++
>  4 files changed, 55 insertions(+), 11 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index aaefa09..d22443e 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -686,8 +686,9 @@ int                     virDomainGetSecurityLabel (virDomainPtr domain,
>   */
>  
>  typedef enum {
> -    VIR_DOMAIN_XML_SECURE = 1, /* dump security sensitive information too */
> -    VIR_DOMAIN_XML_INACTIVE = 2/* dump inactive domain information */
> +    VIR_DOMAIN_XML_SECURE       = (1 << 0), /* dump security sensitive information too */
> +    VIR_DOMAIN_XML_INACTIVE     = (1 << 1), /* dump inactive domain information */
> +    VIR_DOMAIN_XML_UPDATE_CPU   = (1 << 2), /* update guest CPU requirements to match the CPU the guest is currently running on */
>  } virDomainXMLFlags;

Somehow this is not an enum anymore since we logically or the values, but it
is not a serious problem.

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]