[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [1/6] Export virPipeReadUntilEOF internally



On Fri, Mar 26, 2010 at 10:09:53AM -0600, Eric Blake wrote:
> On 03/26/2010 09:41 AM, Daniel Veillard wrote:
> > 
> > Export virPipeReadUntilEOF internally
> > 
> > used to read the data from virExec stdout/err file descriptors
> > 
> > * src/util/util.c src/util/util.h: not static anymore and export it
> > * src/libvirt_private.syms: allow access internally
> 
> ACK.  Minor nit, though:
> 
> >  virParseNumber;
> > +virPipeReadUntilEOF;
> >  virAsprintf;
> >  virRun;
> 
> Is this list intended to be alphabetical?  If so, why is virAsprintf
> where it is?

It is psuedo-alphabetical, by which i mean its alphabetical, except
where it isn't.  It is nice to keep it alpha sorted, but we've not
actively enforced that thus far....patches welcome

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]