[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [4/6] Add the script hook support to the libvirt daemon



On 03/26/2010 09:44 AM, Daniel Veillard wrote:
>  
> +    /* setup the hooks */
> +    virHookInitialize();

Shouldn't this check for a return of -1?

> +
>      /* Disable error func, now logging is setup */
>      virSetErrorFunc(NULL, virshErrorHandler);
>  
> +    /*
> +     * Call the daemon startup hook
> +     */
> +    virHookCall(VIR_HOOK_DRIVER_DAEMON, "-", VIR_HOOK_DAEMON_OP_START,
> +                0, "start", NULL);

For that matter, virHookCall calls virHookInitialize under the hood, do
we need to repeat that ourselves?  And if we don't need to repeat it,
does virHookInitialize still need to be exported?

Should we check for virHookCall failure?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]