[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Introduce UPDATE_CPU flag for virDomainGetXMLDesc



> >  typedef enum {
> > -    VIR_DOMAIN_XML_SECURE = 1, /* dump security sensitive information too */
> > -    VIR_DOMAIN_XML_INACTIVE = 2/* dump inactive domain information */
> > +    VIR_DOMAIN_XML_SECURE       = (1 << 0), /* dump security sensitive information too */
> > +    VIR_DOMAIN_XML_INACTIVE     = (1 << 1), /* dump inactive domain information */
> > +    VIR_DOMAIN_XML_UPDATE_CPU   = (1 << 2), /* update guest CPU requirements to match the CPU the guest is currently running on */
> >  } virDomainXMLFlags;
> 
> Somehow this is not an enum anymore since we logically or the values, but it
> is not a serious problem.

It's been so for ever. This visual renumbering just makes it more visible to
avoid adding new item with inappropriate value.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]