[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable




Eric Blake <eblake redhat com> wrote on 03/30/2010 11:34:41 AM:


> On 03/30/2010 09:26 AM, Stefan Berger wrote:
> > A cosmetic change that makes the entries in the int-2-string maps look
> > more readable.
>
> That's for sure :)
>
> > Add some missing entries.
>
> Is it worth mentioning which ones in the commit message?  Other than
> that, ACK.
>
> >  #endif
> > -    } , {
> > -        .val = NULL,
> > -    }
> > +    INTMAP_ENTRY(IPPROTO_IPV6, "ipv6"),
> > +    INTMAP_ENTRY(IPPROTO_ICMPV6, "icmpv6"),
> > +    INTMAP_ENTRY_LAST
>
> ipv6 and icmpv6 are the only new ones, right?


Correct.

   Stefan

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]