[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/10] xenapi: Use virStrToLong_i instead of sscanf for CPU map parsing



On 03/30/2010 10:20 AM, Matthias Bolte wrote:
> ---
>  src/xenapi/xenapi_utils.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/xenapi/xenapi_utils.c b/src/xenapi/xenapi_utils.c
> index 697ad39..790eebf 100644
> --- a/src/xenapi/xenapi_utils.c
> +++ b/src/xenapi/xenapi_utils.c
> @@ -309,7 +309,8 @@ getCpuBitMapfromString(char *mask, unsigned char *cpumap, int maplen)
>      bzero(cpumap, maplen);
>      num = strtok_r(mask, ",", &bp);
>      while (num != NULL) {
> -        if (sscanf(num, "%d", &pos) != 1)
> +        num += strspn(num, " \t");
> +        if (virStrToLong_i(num, NULL, 10, &pos) < 0)

No need to skip the whitespace yourself.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]