[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix ./configure: line 27875: [: missing `]'



On 03/31/2010 02:35 PM, Matthias Bolte wrote:
> Commit 7998714d60b997357bfea15d6f2d0f729fc8fb29 replaced '-a' with '&& test'
> but this single '-a' needs to stay.
> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 3c3d7b3..fc87e19 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -240,7 +240,7 @@ AC_ARG_WITH([libvirtd],
>  dnl
>  dnl specific tests to setup DV devel environments with debug etc ...
>  dnl
> -if [[ "${LOGNAME}" = "veillard" && test "`pwd`" = "/u/veillard/libvirt" ]] ; then
> +if [[ "${LOGNAME}" = "veillard" -a "`pwd`" = "/u/veillard/libvirt" ]] ; then

NAK.  Instead, we should rewrite this line to use test instead of [.

if test "${LOGNAME}" = "veillard" && test"`pwd`" = "/u/veillar/libvirt"
; then

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]