[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix ./configure: line 27875: [: missing `]'



2010/3/31 Eric Blake <eblake redhat com>:
> On 03/31/2010 02:35 PM, Matthias Bolte wrote:
>> Commit 7998714d60b997357bfea15d6f2d0f729fc8fb29 replaced '-a' with '&& test'
>> but this single '-a' needs to stay.
>> ---
>>  configure.ac |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 3c3d7b3..fc87e19 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -240,7 +240,7 @@ AC_ARG_WITH([libvirtd],
>>  dnl
>>  dnl specific tests to setup DV devel environments with debug etc ...
>>  dnl
>> -if [[ "${LOGNAME}" = "veillard" && test "`pwd`" = "/u/veillard/libvirt" ]] ; then
>> +if [[ "${LOGNAME}" = "veillard" -a "`pwd`" = "/u/veillard/libvirt" ]] ; then
>
> NAK.  Instead, we should rewrite this line to use test instead of [.
>
> if test "${LOGNAME}" = "veillard" && test"`pwd`" = "/u/veillar/libvirt"
> ; then
>

Here's v2 of the patch.

Matthias
From 4ab507297867956ee9a848a6aa88b2598f7e9d6a Mon Sep 17 00:00:00 2001
From: Matthias Bolte <matthias bolte googlemail com>
Date: Wed, 31 Mar 2010 22:53:18 +0200
Subject: [PATCH] Fix ./configure: line 27875: [: missing `]'

Commit 7998714d60b997357bfea15d6f2d0f729fc8fb29 replaced '-a' with '&& test'
and created this broken line 'if [[ .. && test .. ]]; then'.
---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 3c3d7b3..3610136 100644
--- a/configure.ac
+++ b/configure.ac
@@ -240,7 +240,7 @@ AC_ARG_WITH([libvirtd],
 dnl
 dnl specific tests to setup DV devel environments with debug etc ...
 dnl
-if [[ "${LOGNAME}" = "veillard" && test "`pwd`" = "/u/veillard/libvirt" ]] ; then
+if test "${LOGNAME}" = "veillard" && test "`pwd`" = "/u/veillard/libvirt"; then
     STATIC_BINARIES="-static"
 else
     STATIC_BINARIES=
-- 
1.6.3.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]