[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix a virsh edit memory leak



On 04/28/2010 04:27 PM, Chris Lalancette wrote:
When running virsh edit, we are unlinking and setting
the tmp variable to NULL before going to the end of the
function, meaning that we never free tmp.  Since the
exit to the function will always unlink and free tmp,
just remove this bit of code and let it get done at the
end.

Note that the same change is required for cmdInterfaceEdit and cmdNWFilterEdit (which were both cut-paste from cmdEdit). I just sent a patch.

(Sorry I didn't notice it earlier and thus missed the release - I've been away from mail and was just catching up.)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]