[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] build: prefer WIN32 over __MINGW32__ checks



WIN32 is always defined when __MINGW32__ is defined, but the
converse is not true.  WIN32 is more generic, if someone were
to ever attempt porting to a microsoft compiler.  This does
not affect Cygwin, which intentionally does not define WIN32.

* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Use more
generic flag macro.
* src/storage/storage_backend.c
(virStorageBackendUpdateVolTargetInfoFD)
(virStorageBackendRunProgRegex): Likewise.
* tools/console.h (vshRunConsole): Likewise.
---

> for exp in MINGW32 WIN32; do
>   git grep $exp -- tools lib daemon | wc
> done
> 
> shows 4 of the former, and 13 of the latter.  Patch updated accordingly,
> and I'm working on a followup to make it consistent.

Like so.

 src/qemu/qemu_driver.c        |    2 +-
 src/storage/storage_backend.c |    6 +++---
 tools/console.c               |    6 +++---
 tools/console.h               |    6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 08cff00..704f824 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9080,7 +9080,7 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom,
     }

     if (S_ISREG(sb.st_mode)) {
-#ifndef __MINGW32__
+#ifndef WIN32
         info->physical = (unsigned long long)sb.st_blocks *
             (unsigned long long)DEV_BSIZE;
 #else
diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
index 5003b8c..83bbd93 100644
--- a/src/storage/storage_backend.c
+++ b/src/storage/storage_backend.c
@@ -954,7 +954,7 @@ virStorageBackendUpdateVolTargetInfoFD(virStorageVolTargetPtr target,

     if (allocation) {
         if (S_ISREG(sb.st_mode)) {
-#ifndef __MINGW32__
+#ifndef WIN32
             *allocation = (unsigned long long)sb.st_blocks *
                           (unsigned long long)DEV_BSIZE;
 #else
@@ -1184,7 +1184,7 @@ virStorageBackendStablePath(virStoragePoolObjPtr pool,
 }


-#ifndef __MINGW32__
+#ifndef WIN32
 /*
  * Run an external program.
  *
@@ -1466,7 +1466,7 @@ virStorageBackendRunProgNul(virStoragePoolObjPtr pool,
     return 0;
 }

-#else
+#else /* WIN32 */

 int
 virStorageBackendRunProgRegex(virConnectPtr conn,
diff --git a/tools/console.c b/tools/console.c
index 4201ba4..60e62e2 100644
--- a/tools/console.c
+++ b/tools/console.c
@@ -1,7 +1,7 @@
 /*
  * console.c: A dumb serial console client
  *
- * Copyright (C) 2007, 2008 Red Hat, Inc.
+ * Copyright (C) 2007, 2008, 2010 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -22,7 +22,7 @@

 #include <config.h>

-#ifndef __MINGW32__
+#ifndef WIN32

 # include <stdio.h>
 # include <sys/types.h>
@@ -197,4 +197,4 @@ int vshRunConsole(const char *tty) {
     return ret;
 }

-#endif /* !__MINGW32__ */
+#endif /* !WIN32 */
diff --git a/tools/console.h b/tools/console.h
index 683f1cb..d0df78d 100644
--- a/tools/console.h
+++ b/tools/console.h
@@ -1,7 +1,7 @@
 /*
  * console.c: A dumb serial console client
  *
- * Copyright (C) 2007 Red Hat, Inc.
+ * Copyright (C) 2007, 2010 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -23,10 +23,10 @@
 #ifndef __VIR_CONSOLE_H__
 # define __VIR_CONSOLE_H__

-# ifndef __MINGW32__
+# ifndef WIN32

 int vshRunConsole(const char *tty);

-# endif /* !__MINGW32__ */
+# endif /* !WIN32 */

 #endif /* __VIR_CONSOLE_H__ */
-- 
1.6.6.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]