[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: skip interfaces on filter update



On 05/03/2010 11:46 AM, Stefan Berger wrote:
> @@ -1003,15 +1019,29 @@ virNWFilterDomainFWUpdateCB(void *payloa
>                  switch (cb->step) {
>                  case STEP_APPLY_NEW:
>                      cb->err = virNWFilterUpdateInstantiateFilter(cb->conn,
> -                                                                 net);
> +                                                                 net,
> +                                                                 &skipIface);
> +                    if (cb->err == 0 && skipIface == true) {

I probably would have written:
 if (cb->err == 0 && skipIface)
but your longhand comparison to true is okay without requiring touchup.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]