[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] configure.ac: Avoid uname, which breaks cross-compilation



On Tue, May 04, 2010 at 01:41:55AM +0200, Matthias Bolte wrote:
> When cross-compiling on Linux, configure will misdetect the target as
> Linux because it uses uname instead of relying on the $host variable.
> This results in including libvirt_linux.syms into libvirt.syms and
> therefore trying to export undefined symbols.
> 
> Replace uname checks with $host checks to fix this.
> ---
>  configure.ac |   18 ++++++++++++++----
>  1 files changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 6ee5b90..5d68dcc 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -210,8 +210,11 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then
>  fi
>  
>  dnl lxc and qemu drivers require linux headers
> -if test `uname -s` != "Linux"
> -then
> +case "$host" in
> +  *-*-linux*)
> +    # match linux here so the *) case will match anything non-linux
> +    ;;
> +  *)
>      if test "x$with_lxc" != "xyes"
>      then
>          with_lxc=no
> @@ -220,7 +223,8 @@ then
>      then
>          with_qemu=no
>      fi
> -fi
> +    ;;
> +esac
>  
>  dnl Allow to build without Xen, QEMU/KVM, test or remote driver
>  AC_ARG_WITH([xen],
> @@ -1983,7 +1987,13 @@ then
>  fi
>  AM_CONDITIONAL([WITH_NODE_DEVICES], [test "$with_nodedev" = "yes"])
>  
> -AM_CONDITIONAL([WITH_LINUX], [test `uname -s` = "Linux"])
> +with_linux=no
> +case "$host" in
> +  *-*-linux*)
> +    with_linux=yes
> +    ;;
> +esac
> +AM_CONDITIONAL([WITH_LINUX], [test "$with_linux" = "yes"])
>  
>  
>  AC_ARG_WITH([qemu-user],

  ACK, I looked at those recently but completely forgot we were
  cross-compiling for mingw !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]